Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent RefreshController leaking controller #2204

Merged
merged 1 commit into from
Apr 13, 2022
Merged

fix: prevent RefreshController leaking controller #2204

merged 1 commit into from
Apr 13, 2022

Conversation

k-wall
Copy link
Contributor

@k-wall k-wall commented Apr 1, 2022

As exposed by #2202, the RefreshController API leaks the broker that was in the controller role.

@k-wall
fix: prevent RefreshController leaking controller
9842341 
The RefreshController API leaked the broker that was previously in the
controller role.
@dnwe dnwe force-pushed the refreshcontroller-leaks-broker branch from 4f9c5fe to 9842341 Compare April 13, 2022 21:21
@dnwe dnwe changed the title bugfix: RefreshController leaks the broker that was the controller fix: RefreshController leaks the broker that was the controller Apr 13, 2022
@dnwe dnwe added the fix label Apr 13, 2022
@dnwe dnwe changed the title fix: RefreshController leaks the broker that was the controller fix: prevent RefreshController leaking controller Apr 13, 2022
@dnwe dnwe merged commit 2c04192 into IBM:main Apr 13, 2022
dnwe
dnwe reviewed Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

This was referenced May 11, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnwe dnwe dnwe left review comments

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-wall @dnwe